Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix locale not working #70

Merged
merged 1 commit into from
Sep 27, 2023
Merged

Fix locale not working #70

merged 1 commit into from
Sep 27, 2023

Conversation

rbro112
Copy link
Contributor

@rbro112 rbro112 commented Sep 27, 2023

Our compositionLocal we use for snapshots didn't update the context used within it, meaning other locales wouldn't get picked up properly though resources. This sets the local context using the configuration which results in proper locale setting:

com emergetools snapshots sample ui TextRowWithIconPreviewFromMain_loc_de
com emergetools snapshots sample ui TextRowWithIconPreviewFromMain_loc_en

Copy link
Contributor Author

rbro112 commented Sep 27, 2023

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

@rbro112 rbro112 changed the base branch from telkins/find-module-annotations to main September 27, 2023 22:49
@rbro112 rbro112 force-pushed the 09-27-Fix_locale_not_working branch from 13d44b4 to f219b2b Compare September 27, 2023 22:49
@rbro112 rbro112 merged commit 0d0e95c into main Sep 27, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants